Aleksandr Trushkin frx
0 Followers · 1 Following
Repositories
7
 Projects Packages Public Activity Starred Repositories
frx approved frx/kurious#10 2026-07-01 17:11:57 +00:00
Fix #9: No Dockerfile to build service
frx opened issue frx/kurious#9 2026-07-01 16:57:34 +00:00
No Dockerfile to build service
frx approved frx/kurious#8 2026-07-01 09:47:57 +00:00
Fix #7: AGENTS.md is absent in the repository

lgtm

frx opened issue frx/kurious#7 2026-07-01 08:10:04 +00:00
AGENTS.md is absent in the repository
frx approved frx/kurious#6 2026-07-01 07:40:48 +00:00
fix(sravni): update entities to match current sravni.ru API
frx deleted branch refactor/code-review-fixes from frx/kurious 2026-06-28 14:04:26 +00:00
frx pushed to master at frx/kurious 2026-06-28 14:04:26 +00:00
5c529ef060 fix: critical bugs from code review (data corruption, error contract, HTTP hardening) (#5)
frx merged pull request frx/kurious#5 2026-06-28 14:04:25 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)
frx pushed to refactor/code-review-fixes at frx/kurious 2026-06-28 12:57:22 +00:00
ca63e04e7d refactor: move mocks and NotImplemented stubs out of domain package
frx commented on pull request frx/kurious#5 2026-06-28 12:38:31 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Review Responses

1. internal/kurious/ports/http/server.go — Unify ErrNotFound

Let's unify ErrNotFound, why is there both, let's remove domain.ErrNotFound and move…

frx suggested changes for frx/kurious#5 2026-06-28 12:19:02 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Need improvements

frx commented on pull request frx/kurious#5 2026-06-28 12:19:02 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

There are mocks in internal/kurious/domain/repository.go, mocked repository should not be in the domain package. Let's move mocks into adapaters.

frx approved frx/kurious#5 2026-06-28 12:14:26 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)
frx suggested changes for frx/kurious#5 2026-06-28 12:01:42 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)
frx suggested changes for frx/kurious#5 2026-06-28 09:59:21 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)
frx commented on pull request frx/kurious#5 2026-06-28 09:59:21 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Domain package shouldn't depend on any other package

frx suggested changes for frx/kurious#5 2026-06-28 07:24:49 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)
frx commented on pull request frx/kurious#5 2026-06-28 07:24:49 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Let's unify ErrNotFound, why is there both, let's remove domain.ErrNotFound and move completely to errors.ErrNotFound

frx closed issue frx/kurious#3 2026-06-27 22:47:03 +00:00
is this repo alive?
frx opened issue frx/kurious#3 2026-06-27 20:31:07 +00:00
is this repo alive?