frx/kurious
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Fix #12: ydb course repository migrate to new v3 #13

Merged
hermes merged 1 commits from fix/issue-12 into master 2026-07-09 10:51:06 +00:00
Conversation 1 Commits 1 Files Changed 2 +369 -581
hermes commented 2026-07-05 17:12:17 +00:00
Collaborator
Copy Link

Automated fix via OpenCode Engine.

Changes

  • Rewrote ydb_course_repository.go using modern ydb-go-sdk/v3 API patterns:
    • BulkUpsert for batch inserts (replaces manual REPLACE INTO ... FROM AS_TABLE)
    • DoTx for write operations (DELETE, UPDATE)
    • OnlineReadOnlyTxControl() for reads (replaces manual TxControl construction)
    • Added missing ListStatistics method (required by CourseRepository interface)
    • Added GetByExternalID implementation
    • Cleaner param building with explicit DECLARE statements
  • Re-enabled YDB engine in service.go (was returning "ydb is no longer supported")

Verification

  • go vet ./... ✅
  • go build ./... ✅
  • go test ./... ✅ (all existing tests pass)

Closes #12

Automated fix via OpenCode Engine. ## Changes - Rewrote `ydb_course_repository.go` using modern ydb-go-sdk/v3 API patterns: - `BulkUpsert` for batch inserts (replaces manual `REPLACE INTO ... FROM AS_TABLE`) - `DoTx` for write operations (DELETE, UPDATE) - `OnlineReadOnlyTxControl()` for reads (replaces manual TxControl construction) - Added missing `ListStatistics` method (required by CourseRepository interface) - Added `GetByExternalID` implementation - Cleaner param building with explicit DECLARE statements - Re-enabled YDB engine in `service.go` (was returning "ydb is no longer supported") ## Verification - `go vet ./...` ✅ - `go build ./...` ✅ - `go test ./...` ✅ (all existing tests pass) Closes #12
hermes added 1 commit 2026-07-05 17:12:17 +00:00
fix(issue-12): ydb course repository migrate to new v3 1e8adb4da4
frx approved these changes 2026-07-09 10:50:57 +00:00
hermes merged commit 4fe6758b64 into master 2026-07-09 10:51:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
frx
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes frx
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: frx/kurious#13
No description provided.
Delete Branch "fix/issue-12"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?