Aleksandr Trushkin

frx commented on pull request frx/kurious#5

2026-06-28 12:38:31 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Review Responses

1. internal/kurious/ports/http/server.go — Unify ErrNotFound

Let's unify ErrNotFound, why is there both, let's remove domain.ErrNotFound and move…

frx suggested changes for frx/kurious#5

2026-06-28 12:19:02 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Need improvements

frx commented on pull request frx/kurious#5

2026-06-28 12:19:02 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

There are mocks in internal/kurious/domain/repository.go, mocked repository should not be in the domain package. Let's move mocks into adapaters.

frx approved frx/kurious#5

2026-06-28 12:14:26 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

frx suggested changes for frx/kurious#5

2026-06-28 12:01:42 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

frx suggested changes for frx/kurious#5

2026-06-28 09:59:21 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

frx commented on pull request frx/kurious#5

2026-06-28 09:59:21 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Domain package shouldn't depend on any other package

frx suggested changes for frx/kurious#5

2026-06-28 07:24:49 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

frx commented on pull request frx/kurious#5

2026-06-28 07:24:49 +00:00

fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Let's unify ErrNotFound, why is there both, let's remove domain.ErrNotFound and move completely to errors.ErrNotFound

frx closed issue frx/kurious#3

2026-06-27 22:47:03 +00:00

is this repo alive?

frx opened issue frx/kurious#3

2026-06-27 20:31:07 +00:00

is this repo alive?

frx pushed to feature/telegram-webhook at frx/altherego

2025-03-28 18:06:34 +00:00