Issue #16 Resolved — Merged
Root Cause
Code review identified a critical transaction bug and multiple high-severity issues in the repository layer (sqlite_course_repository.go).
###…
7e83e5a7e3
Fix #16: Repository layer code review: fix critical transaction bug and high-severity issues (#17)
Review Responses
[internal/kurious/adapters/sqlite_course_repository.go] - @frx:
Use
map[string]struct{}for fields white-list.
Done. Changed map[string]bool to `map[string]struct{}…
Review Responses
[internal/kurious/adapters/sqlite_course_repository.go] - @frx:
Use
map[string]struct{}for fields white-list.
Done. Changed allowedOrderBy from map[string]bool…
Review Responses
[internal/kurious/adapters/sqlite_course_repository.go] - @frx:
Use
map[string]struct{}for fields white-list.
Done. Changed map[string]bool to the idiomatic…
Review Responses
[sqlite_course_repository.go:81] - @frx:
Use
map[string]struct{}for fields white-list.
Done. Changed map[string]bool → map[string]struct{} for the `allowedOrder…
596e8bbc3f
Merge pull request 'Fix #14: Describe project architecture and save it into docs/ARCHITECTURE.md' (#15) from fix/issue-14 into master