hermes
1 Followers · 0 Following
  • VPS
  • Joined on 2026-06-27
Repositories Projects Packages Public Activity Starred Repositories
hermes pushed to refactor/code-review-fixes at frx/kurious 2026-06-28 10:19:35 +00:00
0d2c4a7c3a fix: remove error types from domain package completely
hermes commented on pull request frx/kurious#5 2026-06-28 10:02:45 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Fixed in bd4a066 — domain no longer imports common/errors. Replaced the alias with errors.New("not implemented") so the domain package has zero internal dependencies.

hermes pushed to refactor/code-review-fixes at frx/kurious 2026-06-28 10:02:38 +00:00
bd4a066d10 fix: remove domain->common/errors import — domain must be dependency-free
hermes commented on pull request frx/kurious#5 2026-06-28 08:19:22 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)

Resolved in 9088caf — removed domain.ErrNotFound entirely, consolidated all usages to errors.ErrNotFound:

  • sqlite_organization_repository.go → cerrors.ErrNotFound
  • `sqlite_learning_cate…
hermes pushed to refactor/code-review-fixes at frx/kurious 2026-06-28 07:56:16 +00:00
9088caf600 fix: unify ErrNotFound — remove domain.ErrNotFound, use errors.ErrNotFound everywhere
hermes created pull request frx/kurious#5 2026-06-28 06:53:20 +00:00
fix: critical bugs from code review (data corruption, error contract, HTTP hardening)
hermes pushed to refactor/code-review-fixes at frx/kurious 2026-06-28 06:53:01 +00:00
4f89f59232 fix(cluster-3): http hardening (M15/M16/M14/C2)
40e5621eb9 fix(cluster-2): error contract unification (C1/M10/M11/M12)
23c29aba1d fix(cluster-1): data corruption fixes (C4/C5/C8)
Compare 3 commits »
hermes created branch refactor/code-review-fixes in frx/kurious 2026-06-28 06:53:01 +00:00
hermes deleted branch add-unit-tests from frx/kurious 2026-06-27 23:23:10 +00:00
hermes pushed to master at frx/kurious 2026-06-27 23:23:03 +00:00
84656c6c56 test: add unit tests for domain and business logic (#4)
hermes merged pull request frx/kurious#4 2026-06-27 23:23:01 +00:00
test: add unit tests for domain and business logic
hermes commented on pull request frx/kurious#4 2026-06-27 23:21:14 +00:00
test: add unit tests for domain and business logic

📋 PR #4 — Triage Review

Files: 3 new test files, 411 lines, 14 tests

✅ What's good

  • Well-structured — table-driven where appropriate, sentinel errors with ErrorIs +…
hermes created pull request frx/kurious#4 2026-06-27 23:13:22 +00:00
test: add unit tests for domain and business logic
hermes pushed to add-unit-tests at frx/kurious 2026-06-27 23:03:45 +00:00
50ee55d83d test: add unit tests for domain and business logic
hermes created branch add-unit-tests in frx/kurious 2026-06-27 23:03:45 +00:00
hermes pushed to master at frx/kurious 2026-06-27 22:47:26 +00:00
39c4fa5621 chore: upgrade Go from 1.22 to 1.26