Fix #1: Pagination resets filters #11

hermes · 2026-07-03T16:17:26Z

hermes commented

2026-07-03 16:17:26 +00:00

Move pagination logic to script and preserve filter query parameters (school_id, order_by, asc, per_page) when navigating between pages.

Added QueryParams field to Pagination struct with pageURL() helper
Server-side: buildListCoursesQueryParams() encodes active filters into pagination links
Client-side: setupPaginationLinks() intercepts pagination clicks, reads current filter state from DOM, builds full URLs preserving all parameters
Added data-paginated/data-base-url/data-current-page attributes to pagination nav for JS targeting

Closes #1

Move pagination logic to script and preserve filter query parameters (school_id, order_by, asc, per_page) when navigating between pages. - Added `QueryParams` field to `Pagination` struct with `pageURL()` helper - Server-side: `buildListCoursesQueryParams()` encodes active filters into pagination links - Client-side: `setupPaginationLinks()` intercepts pagination clicks, reads current filter state from DOM, builds full URLs preserving all parameters - Added `data-paginated`/`data-base-url`/`data-current-page` attributes to pagination nav for JS targeting Closes #1

hermes added 1 commit 2026-07-03 16:17:27 +00:00

fix(issue-1): Pagination resets filters 6d1f526394

Move pagination logic to preserve filter query parameters (school_id,
order_by, asc, per_page) when navigating between pages.

- Added QueryParams field to Pagination struct and pageURL() helper
- Server-side: buildListCoursesQueryParams() encodes active filters into
  pagination links as query string
- Client-side: setupPaginationLinks() intercepts pagination link clicks,
  reads current filter state from DOM selects, and constructs full URLs
  with all parameters preserved
- Added data-paginated/data-base-url/data-current-page attributes to
  pagination nav for JS targeting

Closes #1

frx approved these changes 2026-07-03 16:19:51 +00:00

frx left a comment

lgtm

hermes merged commit 91c1778a5e into master

2026-07-03 16:19:56 +00:00

hermes referenced this issue from a commit

2026-07-03 16:19:58 +00:00

Merge pull request 'Fix #1: Pagination resets filters' (#11) from fix/issue-1 into master

hermes referenced this pull request

2026-07-03 16:20:25 +00:00

Pagination resets filters #1

hermes referenced this pull request