Fix #16: Repository layer code review: fix critical transaction bug and high-severity issues (#17)

Per review feedback on PR #17, comment #137: use map[string]struct{}
(set semantics) instead of map[string]bool for the ORDER BY field
whitelist. Updates the lookup to comma-ok idiom.

internal/kurious/adapters/sqlite_course_repository.go

@@ -78,16 +78,16 @@ func (r *sqliteCourseRepository) List(
 		direction = "DESC"
 	}
 
-	allowedOrderBy := map[string]bool{
+	allowedOrderBy := map[string]struct{}{
-		"id":         true,
+		"id":         {},
-		"name":       true,
+		"name":       {},
-		"created_at": true,
+		"created_at": {},
-		"updated_at": true,
+		"updated_at": {},
-		"full_price": true,
+		"full_price": {},
-		"discount":   true,
+		"discount":   {},
-		"duration":   true,
+		"duration":   {},
 	}
-	if !allowedOrderBy[params.OrderBy] {
+	if _, ok := allowedOrderBy[params.OrderBy]; !ok {
 		return result, fmt.Errorf("invalid order by field: %s", params.OrderBy)
 	}